Project

General

Profile

Bug #13525

mon: should not set isvalid = true when cephx_verify_authorizer return false

Added by Ruifeng Yang about 3 years ago. Updated over 2 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
10/19/2015
Due date:
% Done:

0%

Source:
other
Tags:
Backport:
infernalis,hammer
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:

Description

if (authorizer_data.length()) {
  int ret = cephx_verify_authorizer(g_ceph_context, &keyring, iter,
                                    auth_ticket_info, authorizer_reply);
  if (ret >= 0) { //bad!
    session_key = auth_ticket_info.session_key;
    isvalid = true;
  } else {
    dout(0) << "ms_verify_authorizer bad authorizer from mon " << con->get_peer_addr() << dendl;
  }
}

should use bool instead of int
master PR: https://github.com/ceph/ceph/pull/6306


Related issues

Copied to Ceph - Backport #13589: infernalis: mon: should not set isvalid = true when cephx_verify_authorizer return false Resolved
Copied to Ceph - Backport #13590: mon: should not set isvalid = true when cephx_verify_authorizer return false Resolved

Associated revisions

Revision c7f75b8f (diff)
Added by Ruifeng Yang about 3 years ago

mon: should not set isvalid = true when cephx_verify_authorizer return false

Fixes: #13525
Signed-off-by: Ruifeng Yang <>

Revision 9085c820 (diff)
Added by Ruifeng Yang almost 3 years ago

mon: should not set isvalid = true when cephx_verify_authorizer return false

Fixes: #13525
Signed-off-by: Ruifeng Yang <>
(cherry picked from commit c7f75b8f7c0a773148ec16141941efd00ee76626)

Revision 8707b0b0 (diff)
Added by Ruifeng Yang almost 3 years ago

mon: should not set isvalid = true when cephx_verify_authorizer return false

Fixes: #13525
Signed-off-by: Ruifeng Yang <>
(cherry picked from commit c7f75b8f7c0a773148ec16141941efd00ee76626)

Revision 8fb306c3 (diff)
Added by Ruifeng Yang almost 3 years ago

mon: should not set isvalid = true when cephx_verify_authorizer return false

Fixes: #13525
Signed-off-by: Ruifeng Yang <>
(cherry picked from commit c7f75b8f7c0a773148ec16141941efd00ee76626)

History

#1 Updated by Kefu Chai almost 3 years ago

  • Status changed from New to Need Review

#2 Updated by Sage Weil almost 3 years ago

  • Status changed from Need Review to Pending Backport
  • Assignee deleted (Ruifeng Yang)
  • Backport set to infernalis,hammer,firefly

#3 Updated by Nathan Cutler almost 3 years ago

  • Copied to Backport #13589: infernalis: mon: should not set isvalid = true when cephx_verify_authorizer return false added

#4 Updated by Nathan Cutler almost 3 years ago

  • Copied to Backport #13590: mon: should not set isvalid = true when cephx_verify_authorizer return false added

#5 Updated by Nathan Cutler almost 3 years ago

  • Copied to Backport #13591: mon: should not set isvalid = true when cephx_verify_authorizer return false added

#6 Updated by Loic Dachary over 2 years ago

  • Backport changed from infernalis,hammer,firefly to infernalis,hammer

#7 Updated by Loic Dachary over 2 years ago

  • Copied to deleted (Backport #13591: mon: should not set isvalid = true when cephx_verify_authorizer return false)

#8 Updated by Loic Dachary over 2 years ago

  • Status changed from Pending Backport to Resolved

#9 Updated by Samuel Just over 2 years ago

  • Related to Bug #13826: segfault from PrebufferedStreambuf::overflow added

#10 Updated by Kefu Chai over 2 years ago

  • Related to deleted (Bug #13826: segfault from PrebufferedStreambuf::overflow)

#11 Updated by Kefu Chai over 2 years ago

  • Duplicated by Bug #13826: segfault from PrebufferedStreambuf::overflow added

#12 Updated by Brad Hubbard over 2 years ago

  • Duplicated by deleted (Bug #13826: segfault from PrebufferedStreambuf::overflow)

Also available in: Atom PDF