Project

General

Profile

Actions
Copy link

Bug #1351

closed

rados bench should report errors

Added by Greg Farnum over 12 years ago. Updated over 12 years ago.

Status:
Resolved
Priority:
High
Assignee:
Greg Farnum
Category:
qa
Target version:
v0.39
% Done:

0%

Source:
Tags:
Backport:
Regression:
Severity:
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

Right now if you get eg a perm error on write, rados bench just keeps looping waiting for the write to complete. That's clearly wrong, and wherever the problem is it should be propagated back to the user and result in program termination.

Actions
Copy link
 #1

Updated by Sage Weil over 12 years ago

  • Target version changed from v0.34 to v0.35
  • Translation missing: en.field_position set to 1
Actions
Copy link
 #2

Updated by Sage Weil over 12 years ago

  • Translation missing: en.field_position deleted (11)
  • Translation missing: en.field_position set to 31
Actions
Copy link
 #3

Updated by Sage Weil over 12 years ago

  • Target version changed from v0.35 to v0.36
  • Translation missing: en.field_position deleted (29)
  • Translation missing: en.field_position set to 1
Actions
Copy link
 #4

Updated by Sage Weil over 12 years ago

  • Translation missing: en.field_story_points set to 1
  • Translation missing: en.field_position deleted (43)
  • Translation missing: en.field_position set to 37
Actions
Copy link
 #5

Updated by Sage Weil over 12 years ago

  • Target version deleted (v0.36)
  • Translation missing: en.field_position deleted (43)
  • Translation missing: en.field_position set to 8
Actions
Copy link
 #6

Updated by Josh Durgin over 12 years ago

  • Priority changed from Normal to High

This is probably what caused #1734.

Actions
Copy link
 #7

Updated by Sage Weil over 12 years ago

  • Target version set to v0.39
  • Translation missing: en.field_position deleted (41)
  • Translation missing: en.field_position set to 6
Actions
Copy link
 #8

Updated by Sage Weil over 12 years ago

  • Assignee set to Greg Farnum
Actions
Copy link
 #9

Updated by Greg Farnum over 12 years ago

Quick skim analysis:
If there's an error, the OSD returns it as an ACK.
The objecter only sends back data on the replies you requested. So if you asked for a commit and get an ack, it drops it on the floor. But the OSD is done, so...
Hang!

Should be a simple matter of getting the objecter to return any error return code to all requested contexts. (Although I'm not sure rados bench actually checks them, so there's that too.)

Actions
Copy link
 #10

Updated by Greg Farnum over 12 years ago

  • Status changed from New to Resolved
Actions
Copy link

Also available in: Atom PDF