Project

General

Profile

Bug #13471

OSD::build_past_intervals_parallel() shall reset primary and up_primary when begin a new past_interval.

Added by xie xingguo about 3 years ago. Updated over 2 years ago.

Status:
Resolved
Priority:
Urgent
Assignee:
-
Category:
-
Target version:
-
Start date:
10/13/2015
Due date:
% Done:

0%

Source:
other
Tags:
Backport:
hammer,infernalis
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:

Description

void OSD::build_past_intervals_parallel()
if (new_interval) {
dout(10) << func << " epoch " << cur_epoch << " pg " << pg->info.pgid
<< " " << debug.str() << dendl;
p.old_up = up;
p.old_acting = acting;
p.same_interval_since = cur_epoch;
}

See above. If we successfully start over a new_interval? the current code logic seems to forget update the p.primary and p.up_primary field
simultaneously which I think is problematic.


Related issues

Copied to Ceph - Backport #13588: OSD::build_past_intervals_parallel() shall reset primary and up_primary when begin a new past_interval. Resolved
Copied to Ceph - Backport #13615: OSD::build_past_intervals_parallel() shall reset primary and up_primary when begin a new past_interval. Resolved

Associated revisions

Revision 65064ca0 (diff)
Added by xie xingguo about 3 years ago

OSD:shall reset primary and up_primary fields when beginning a new past_interval.

Shall reset primary and up_primary fields when we start over a new past_interval in OSD::build_past_intervals_parallel().
Fixes: #13471
Signed-off-by:

Revision fde4ec62 (diff)
Added by xie xingguo almost 3 years ago

OSD:shall reset primary and up_primary fields when beginning a new past_interval.

Shall reset primary and up_primary fields when we start over a new past_interval in OSD::build_past_intervals_parallel().
Fixes: #13471
Signed-off-by:
(cherry picked from commit 65064ca05bc7f8b6ef424806d1fd14b87add62a4)

Revision ade0f1a4 (diff)
Added by xie xingguo almost 3 years ago

OSD:shall reset primary and up_primary fields when beginning a new past_interval.

Shall reset primary and up_primary fields when we start over a new past_interval in OSD::build_past_intervals_parallel().
Fixes: #13471
Signed-off-by:
(cherry picked from commit 65064ca05bc7f8b6ef424806d1fd14b87add62a4)

History

#2 Updated by Kefu Chai about 3 years ago

  • Status changed from New to Need Review
  • Assignee set to xie xingguo

#3 Updated by Sage Weil almost 3 years ago

  • Status changed from Need Review to Pending Backport
  • Assignee deleted (xie xingguo)
  • Backport set to hammer

#4 Updated by Nathan Cutler almost 3 years ago

  • Copied to Backport #13588: OSD::build_past_intervals_parallel() shall reset primary and up_primary when begin a new past_interval. added

#5 Updated by Nathan Cutler almost 3 years ago

  • Backport changed from hammer to hammer,infernalis

#6 Updated by Nathan Cutler almost 3 years ago

  • Copied to Backport #13615: OSD::build_past_intervals_parallel() shall reset primary and up_primary when begin a new past_interval. added

#7 Updated by Nathan Cutler over 2 years ago

  • Status changed from Pending Backport to Resolved

Also available in: Atom PDF