Bug #13471
OSD::build_past_intervals_parallel() shall reset primary and up_primary when begin a new past_interval.
0%
Description
void OSD::build_past_intervals_parallel()
if (new_interval)
{
dout(10) << func << " epoch " << cur_epoch << " pg " << pg->info.pgid
<< " " << debug.str() << dendl;
p.old_up = up;
p.old_acting = acting;
p.same_interval_since = cur_epoch;
}
See above. If we successfully start over a new_interval? the current code logic seems to forget update the p.primary and p.up_primary field
simultaneously which I think is problematic.
Related issues
Associated revisions
OSD:shall reset primary and up_primary fields when beginning a new past_interval.
Shall reset primary and up_primary fields when we start over a new past_interval in OSD::build_past_intervals_parallel().
Fixes: #13471
Signed-off-by: xie.xingguo@zte.com.cn
OSD:shall reset primary and up_primary fields when beginning a new past_interval.
Shall reset primary and up_primary fields when we start over a new past_interval in OSD::build_past_intervals_parallel().
Fixes: #13471
Signed-off-by: xie.xingguo@zte.com.cn
(cherry picked from commit 65064ca05bc7f8b6ef424806d1fd14b87add62a4)
OSD:shall reset primary and up_primary fields when beginning a new past_interval.
Shall reset primary and up_primary fields when we start over a new past_interval in OSD::build_past_intervals_parallel().
Fixes: #13471
Signed-off-by: xie.xingguo@zte.com.cn
(cherry picked from commit 65064ca05bc7f8b6ef424806d1fd14b87add62a4)
History
#1 Updated by xie xingguo over 8 years ago
#2 Updated by Kefu Chai over 8 years ago
- Status changed from New to Fix Under Review
- Assignee set to xie xingguo
#3 Updated by Sage Weil over 8 years ago
- Status changed from Fix Under Review to Pending Backport
- Assignee deleted (
xie xingguo) - Backport set to hammer
#4 Updated by Nathan Cutler over 8 years ago
- Copied to Backport #13588: OSD::build_past_intervals_parallel() shall reset primary and up_primary when begin a new past_interval. added
#5 Updated by Nathan Cutler over 8 years ago
- Backport changed from hammer to hammer,infernalis
#6 Updated by Nathan Cutler over 8 years ago
- Copied to Backport #13615: OSD::build_past_intervals_parallel() shall reset primary and up_primary when begin a new past_interval. added
#7 Updated by Nathan Cutler about 8 years ago
- Status changed from Pending Backport to Resolved