Bug #13206: OSD::do_recovery() local variable "started" shall be explicitly initialized to zero - Ceph - Ceph

Actions

Copy link

Bug #13206

closed

OSD::do_recovery() local variable "started" shall be explicitly initialized to zero

Added by xie xingguo over 8 years ago. Updated over 8 years ago.

Status:

Resolved

Priority:

High

Assignee:

Category:

Target version:

% Done:

Source:

other

Tags:

Backport:

Regression:

Severity:

3 - minor

Reviewed:

Affected Versions:

v0.94.2

ceph-qa-suite:

Pull request ID:

Crash signature (v1):

Crash signature (v2):

Description

void OSD::do_recovery(PG *pg, ThreadPool::TPHandle &handle)

int started;
    bool more = pg->start_recovery_ops(max, &rctx, handle, &started);

See above, the local variable 'started' is not explicitly initialized to zero before it is passed into pg->start_recovery_ops(),
thus the initial value of "started" is completed determined by the compiler and the pg->start_recovery_ops() may don't work as it
is supposed to be.