Actions
Bug #13177
closedrhel 5.9 doesn't compile (librados only) due to blkid error
% Done:
0%
Source:
other
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):
Description
Changes introduced in configure.ac check for blkid functions which don't exist on rhel 5.9. off master the configure executes, but on compilation:
common/blkdev.cc: In function 'int block_device_discard(int, int64_t, int64_t)':
common/blkdev.cc:177:20: error: 'BLKDISCARD' was not declared in this scope
return ioctl(fd, BLKDISCARD, range);
^
common/blkdev.cc:178:1: warning: control reaches end of non-void function [-Wreturn-type]
}
I've created a simple fix which put blkid work into RBD build scope.
Updated by Rohan Mars over 8 years ago
Actually, configure.ac is probably fine, but a requires Makefile.am check to exclude blkid for librados only compile on RHEL 5.9. But it makes sense to me to exclude blkid unless compiling RBD.
Actions