Project

General

Profile

Bug #13177

rhel 5.9 doesn't compile (librados only) due to blkid error

Added by Rohan Mars about 3 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Target version:
-
Start date:
09/20/2015
Due date:
% Done:

0%

Source:
other
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:

Description

Changes introduced in configure.ac check for blkid functions which don't exist on rhel 5.9. off master the configure executes, but on compilation:

common/blkdev.cc: In function 'int block_device_discard(int, int64_t, int64_t)':
common/blkdev.cc:177:20: error: 'BLKDISCARD' was not declared in this scope
return ioctl(fd, BLKDISCARD, range);
^
common/blkdev.cc:178:1: warning: control reaches end of non-void function [-Wreturn-type]
}

I've created a simple fix which put blkid work into RBD build scope.

https://github.com/ceph/ceph/pull/5954

Associated revisions

Revision 937e4f88 (diff)
Added by Rohan Mars about 3 years ago

rhel 5.9 librados fix, removed blkid from compilation, Fixes #13177

History

#1 Updated by Rohan Mars about 3 years ago

Actually, configure.ac is probably fine, but a requires Makefile.am check to exclude blkid for librados only compile on RHEL 5.9. But it makes sense to me to exclude blkid unless compiling RBD.

#2 Updated by Sage Weil about 3 years ago

  • Assignee set to Rohan Mars

#3 Updated by Sage Weil over 1 year ago

  • Status changed from New to Closed

Also available in: Atom PDF