Project

General

Profile

Actions

Bug #13089

closed

mon: check for store writeablility before participating in election

Added by Samuel Just over 8 years ago. Updated about 8 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
-
% Done:

0%

Source:
other
Tags:
Backport:
hammer,firefly
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Related issues 3 (0 open3 closed)

Has duplicate Ceph - Bug #13200: mon: does not check for IO errors on every transactionDuplicate09/22/2015

Actions
Copied to Ceph - Backport #13339: mon: check for store writeablility before participating in electionResolvedLoïc DacharyActions
Copied to Ceph - Backport #13252: mon: does not check for IO errors on every transactionResolved09/22/2015Actions
Actions #1

Updated by Greg Farnum over 8 years ago

Mmm, I'm not sure we want to do the naive thing (write a file and fsync) on every election as that will slow them down a lot in the common case. Probably if we just check store accessibility on bootup, flip a flag if we ever fail one, and check for it on every election?

Actions #2

Updated by Sage Weil over 8 years ago

Greg Farnum wrote:

Mmm, I'm not sure we want to do the naive thing (write a file and fsync) on every election as that will slow them down a lot in the common case. Probably if we just check store accessibility on bootup, flip a flag if we ever fail one, and check for it on every election?

Yeah I think a check on boot is sufficient.

Actions #3

Updated by Kefu Chai over 8 years ago

  • Assignee set to Kefu Chai
Actions #4

Updated by Joao Eduardo Luis over 8 years ago

Can we have a bit more context please? What's the rationale behind this? The monitor should not start if leveldb is not open, and since it's not open it's not writeable. Is this in case the disk is full or the fs is read-only? Or something else I'm missing?

Actions #5

Updated by Kefu Chai over 8 years ago

  • Status changed from New to Fix Under Review
  • Assignee changed from Kefu Chai to Sage Weil
Actions #6

Updated by Kefu Chai over 8 years ago

  • Tags set to hammer
Actions #7

Updated by Kefu Chai over 8 years ago

  • Tags deleted (hammer)
  • Backport set to hammer
Actions #8

Updated by Sage Weil over 8 years ago

  • Status changed from Fix Under Review to Pending Backport
Actions #9

Updated by Loïc Dachary over 8 years ago

  • Backport changed from hammer to hammer,firefly
Actions #10

Updated by Loïc Dachary over 8 years ago

  • Status changed from Pending Backport to Resolved
Actions #11

Updated by Kefu Chai about 8 years ago

please note that the background compaction fails, if leveldb can not create new tables or remove merged tables.

so, if we "chmod -w store.db". and leveldb complains in this case, but it does not return error on Write() unless "leveldb_paranoid" is true, but this option is "false" by default. so "failed to write to db" assertion is not triggered, even if compaction fails with the default settings.

Actions

Also available in: Atom PDF