https://tracker.ceph.com/
https://tracker.ceph.com/favicon.ico
2015-09-14T18:42:19Z
Ceph
Ceph - Bug #13088: a73a4cb breaks "--without-libatomic-ops" (firefly)
https://tracker.ceph.com/issues/13088?journal_id=58516
2015-09-14T18:42:19Z
Greg Farnum
gfarnum@redhat.com
<ul></ul><p>That's odd:</p>
<pre>#else
/*
* crappy slow implementation that uses a pthreads spinlock.
*/
#include "include/Spinlock.h"
namespace ceph {
typedef atomic_spinlock_t<unsigned> atomic_t;
typedef atomic_spinlock_t<unsigned long long> atomic64_t;
}
#endif</pre>
<p>definitely specifies atomic_t. Unless it's the nested #ifs:</p>
<pre>
#ifndef NO_ATOMIC_OPS
[ definition goes here...]
#if SIZEOF_AO_T == 8
typedef atomic_t atomic64_t;
#else
typedef atomic_spinlock_t<unsigned long long> atomic64_t;
#endif
}
#else
/*
* crappy slow implementation that uses a pthreads spinlock.
*/
</pre>
<p>The internet tells me we can nest them, but that's the only thing I can see that might have broken them.</p>
Ceph - Bug #13088: a73a4cb breaks "--without-libatomic-ops" (firefly)
https://tracker.ceph.com/issues/13088?journal_id=58987
2015-09-22T14:59:31Z
Sage Weil
sage@newdream.net
<ul><li><strong>Priority</strong> changed from <i>Normal</i> to <i>Urgent</i></li></ul>
Ceph - Bug #13088: a73a4cb breaks "--without-libatomic-ops" (firefly)
https://tracker.ceph.com/issues/13088?journal_id=59006
2015-09-22T19:31:16Z
Sage Weil
sage@newdream.net
<ul><li><strong>Subject</strong> changed from <i>a73a4cb breaks "--without-libatomic-ops"</i> to <i>a73a4cb breaks "--without-libatomic-ops" (firefly)</i></li><li><strong>Status</strong> changed from <i>New</i> to <i>Fix Under Review</i></li></ul><p><a class="external" href="https://github.com/ceph/ceph/pull/6038">https://github.com/ceph/ceph/pull/6038</a></p>
Ceph - Bug #13088: a73a4cb breaks "--without-libatomic-ops" (firefly)
https://tracker.ceph.com/issues/13088?journal_id=59069
2015-09-23T21:09:30Z
Sage Weil
sage@newdream.net
<ul><li><strong>Status</strong> changed from <i>Fix Under Review</i> to <i>Resolved</i></li></ul>