Project

General

Profile

Actions
Copy link

Bug #127

closed

fix r_aborted locking

Added by Sage Weil almost 14 years ago. Updated over 13 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Sage Weil
Category:
-
Target version:
v2.6.35
% Done:

0%

Source:
Tags:
Backport:
Regression:
Severity:
Reviewed:
Affected Versions:
ceph-qa-suite:
Crash signature (v1):
Crash signature (v2):

Description

r_aborted is protected by mdsc->mutex (along with r_reply, r_err), but it tested during fill_trace under s_mutex. is a memory barrier sufficient?

Actions
Copy link
 #1

Updated by Sage Weil almost 14 years ago

no, there needs to be some locking. if we abort and return to the caller, we need to know that fill_trace isn't doing things that must be protected by the dir mutex.

add a request mutex just for this case?

Actions
Copy link
 #2

Updated by Sage Weil almost 14 years ago

  • Status changed from New to In Progress
Actions
Copy link
 #3

Updated by Sage Weil almost 14 years ago

  • Assignee set to Sage Weil
Actions
Copy link
 #4

Updated by Sage Weil almost 14 years ago

  • Status changed from In Progress to Resolved
Actions
Copy link

Also available in: Atom PDF