Bug #12401
pgmonitor: wrong "at/near target max“ reporting
0%
Description
we set pool's target_max_bytes to 89000000000000(89TB),
but when the pool use 29561632420936B,
the "ceph health detail" reports "cache pool 'myEC1-autocache' with 27531GB at/near target max 82887GB"
after add some extra output info, we get this:
2015-07-20 09:40:48.704394 7f623868e700 0 mon.lab8101@0(leader).pg v357987 cache pool 'myEC1-autocache' with 29561632420936B at/near target max 89000000000000B ratio 932000 cache_target_full_ratio_micro 800000 mon_cache_target_full_warn_ratio 0.66 target_max_bytes*ratio/1000000 9161023705161
it seems the uint64_t can not hold "89000000000000*932000" which large than 2^64;
Related issues
Associated revisions
mon/PGMonitor: avoid uint64_t overflow when checking pool 'target/max' status.
Fixes: #12401
Signed-off-by: huangjun <hjwsm1989@gmail.com>
mon/PGMonitor: avoid uint64_t overflow when checking pool 'target/max' status.
Fixes: #12401
Signed-off-by: huangjun <hjwsm1989@gmail.com>
(cherry picked from commit f84e6b8157e78fd05cd1c8ac957c92df17e6ba06)
mon/PGMonitor: avoid uint64_t overflow when checking pool 'target/max' status.
Fixes: #12401
Signed-off-by: huangjun <hjwsm1989@gmail.com>
(cherry picked from commit f84e6b8157e78fd05cd1c8ac957c92df17e6ba06)
History
#1 Updated by Kefu Chai over 8 years ago
- Status changed from New to Fix Under Review
- Backport set to firefly, hammer
#2 Updated by Kefu Chai over 8 years ago
- Assignee set to huang jun
#3 Updated by Kefu Chai over 8 years ago
#4 Updated by Kefu Chai over 8 years ago
- Status changed from Fix Under Review to Pending Backport
#5 Updated by huang jun over 8 years ago
hi, kefu, who is going to do backport of this?
#6 Updated by Nathan Cutler over 8 years ago
Hi Huang: firefly backport is ready for you to review at #12495 and hammer backport at #12496. In general, as a developer you don't have to worry about backporting unless the fix is so complicated that we in the Stable Releases and Backports team are not able to do the work ourselves, in which case we will contact you.
See http://tracker.ceph.com/projects/ceph-releases/wiki for more information.
#7 Updated by Nathan Cutler over 8 years ago
- Status changed from Pending Backport to Resolved