Project

General

Profile

Bug #12166

ceph.spec.in: 50-rbd.rules conditional is wrong

Added by Nathan Cutler over 3 years ago. Updated about 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
-
Start date:
06/25/2015
Due date:
% Done:

0%

Source:
Community (dev)
Tags:
Backport:
hammer,firefly
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:

Description

The conditional currently says:

%if 0%{?rhel} >= 7 || 0%{?fedora}
/usr/lib/udev/rules.d/50-rbd.rules
%else
/lib/udev/rules.d/50-rbd.rules
%endif

which on SUSE/openSUSE has the effect of putting 50-rbd.rules in /lib/udev/rules.d, regardless of distro version.

The conditional governing the install is similarly inadequate.

And the conditionals for the other udev rules files also suffer from the same issue.


Related issues

Duplicated by devops - Bug #12164: ceph.spec.in: 50-rbd.rules conditional is wrong Duplicate 06/25/2015
Copied to devops - Backport #12266: ceph.spec.in: 50-rbd.rules conditional is wrong Resolved 06/25/2015
Copied to devops - Backport #12267: ceph.spec.in: 50-rbd.rules conditional is wrong Resolved 06/25/2015

Associated revisions

Revision 8aa758ee (diff)
Added by Nathan Cutler over 3 years ago

ceph.spec.in: use _udevrulesdir to eliminate conditionals

The conditionals governing where 50-rbd.rules is installed were not doing the
right thing on SUSE distros.

Start using the %_udevrulesdir RPM macro, while taking care that it is defined
and set to the right value. Use it to eliminate some conditionals around other
udev rules files as well.

http://tracker.ceph.com/issues/12166 Fixes: #12166

Signed-off-by: Nathan Cutler <>

Revision 4eb58ad2 (diff)
Added by Nathan Cutler over 3 years ago

ceph.spec.in: use _udevrulesdir to eliminate conditionals

The conditionals governing where 50-rbd.rules is installed were not doing the
right thing on SUSE distros.

Start using the %_udevrulesdir RPM macro, while taking care that it is defined
and set to the right value. Use it to eliminate some conditionals around other
udev rules files as well.

http://tracker.ceph.com/issues/12166 Fixes: #12166

Signed-off-by: Nathan Cutler <>
(cherry picked from commit 8aa758ee7a14e93ded1d55b4aca7a54aa47d7174)

Conflicts:
ceph.spec.in
hammer does not yet have _with_systemd or ceph_daemon.py

Revision 68508e28 (diff)
Added by Nathan Cutler over 3 years ago

ceph.spec.in: use _udevrulesdir to eliminate conditionals

The conditionals governing where 50-rbd.rules is installed were not doing the
right thing on SUSE distros.

Start using the %_udevrulesdir RPM macro, while taking care that it is defined
and set to the right value. Use it to eliminate some conditionals around other
udev rules files as well.

http://tracker.ceph.com/issues/12166 Fixes: #12166

Signed-off-by: Nathan Cutler <>
(cherry picked from commit 8aa758ee7a14e93ded1d55b4aca7a54aa47d7174)

Conflicts:
ceph.spec.in
master spec file has diverged significantly from firefly

History

#1 Updated by Nathan Cutler over 3 years ago

  • Status changed from New to Need Review
  • Assignee changed from Nathan Cutler to Ken Dreyer

#2 Updated by Nathan Cutler over 3 years ago

  • Status changed from Need Review to Resolved

#3 Updated by Nathan Cutler over 3 years ago

  • Status changed from Resolved to Pending Backport

#4 Updated by Nathan Cutler about 3 years ago

  • Status changed from Pending Backport to Resolved

#5 Updated by Nathan Cutler almost 3 years ago

  • Duplicated by Bug #12164: ceph.spec.in: 50-rbd.rules conditional is wrong added

Also available in: Atom PDF