Actions
Feature #12038
closedmake rgw_fronends more forgiving of whitespace
% Done:
0%
Source:
Development
Tags:
Backport:
hammer
Reviewed:
Affected Versions:
Pull request ID:
Updated by Ken Dreyer almost 9 years ago
The original downstream report has a bit more info: https://bugzilla.redhat.com/show_bug.cgi?id=1228845
Updated by Michal Jarzabek almost 9 years ago
Updated by Matt Benjamin over 8 years ago
I've pushed branch wip-civetwarn to git@github.com:linuxbox2/ceph.git
Yehuda intended to suggest some changes, I don't think he has yet. I've resubmitted it has upstream PR #6944
Updated by Yehuda Sadeh over 8 years ago
I did comment on the PR, or on the commit. But I can't find my comments now. Could it be that it got lost due to re-pushing the code?
Updated by Matt Benjamin over 8 years ago
I've updated PR with what I recall were your original verbal comments:
1. don't warn just because "port" missing
2. refer to upstream feature, not the BZ in the commit msg (and remove comment mentioning it from the code)
Updated by Ken Dreyer over 8 years ago
- Status changed from New to Fix Under Review
- Assignee set to Matt Benjamin
PR for master is https://github.com/ceph/ceph/pull/6944
Updated by Ken Dreyer over 8 years ago
- Status changed from Fix Under Review to Pending Backport
Updated by Loïc Dachary about 8 years ago
- Copied to Backport #14493: hammer: make rgw_fronends more forgiving of whitespace added
Updated by Loïc Dachary about 8 years ago
- Status changed from Pending Backport to Resolved
Actions