Project

General

Profile

Actions

Bug #11645

closed

teuthology-suite ignores kernel_flavor when polling gitbuilders

Added by Zack Cerza almost 9 years ago. Updated almost 9 years ago.

Status:
Resolved
Priority:
Urgent
Assignee:
Category:
-
% Done:

0%

Source:
other
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Crash signature (v1):
Crash signature (v2):

Description

This is to prevent things like #11591

Actions #1

Updated by Zack Cerza almost 9 years ago

  • Status changed from In Progress to Fix Under Review
Actions #2

Updated by Zack Cerza almost 9 years ago

[13:45:43]  <sage>    zackc: that will iterator over each test yaml in the run, and get the needed flavor from it, right?
[13:48:49]  <zackc>    sage: do individual tests override the kernel flavor somehow?
[14:09:41]  <gregsfortytwo>    zackc: that's the only thing that does set them that I'm aware of
[14:10:00]  <gregsfortytwo>    the yaml associated with a job, that is
[14:10:12]  <gregsfortytwo>    it's not a suite-wide setting
[14:13:14]  <zackc>    it's definitely a suite-wide setting
[14:20:08]  <gregsfortytwo>    okay, if you grep in ceph-qa-suite there are several matches for "flavor: notcmalloc" 
[14:20:24]  <gregsfortytwo>    and I think those are the only things currently running that set the flavor :)
[14:20:36]  <gregsfortytwo>    zackc: ^
[14:23:54]  <zackc>    sigh. i didn't even know about that
[14:24:05]  <zackc>    everywhere i ever saw "flavor", it was called "kernel flavor" 
[14:24:15]  <zackc>    these are stuffing flavor into the install task
[14:28:34]  <zackc>    wow nothing is actually using teuthology-suite --flavor
[14:30:55]  <zackc>    that means my PR won't fix anything at all.
[14:35:53]  <gregsfortytwo>    yeah, I thought the dead gitbuilder was a notcmalloc one, which definitely isn't related to the kernel ;)
[14:52:39]  <zackc>    there goes all my understanding of what a 'flavor' is

Back to the drawing board, I guess, once I know what I'm supposed to draw this time.

Actions #3

Updated by Zack Cerza almost 9 years ago

  • Status changed from Fix Under Review to Resolved

I added functionality to poke into the install task's configuration for its flavor. Merged all of it this morning.

https://github.com/ceph/teuthology/commit/04b5e6ec093933d74307749f33256327ac66031e

Actions

Also available in: Atom PDF