Project

General

Profile

Bug #11602

crush: take crashes due to invalid arg

Added by Sage Weil over 3 years ago. Updated about 3 years ago.

Status:
Resolved
Priority:
Urgent
Assignee:
-
Category:
-
Target version:
-
Start date:
05/12/2015
Due date:
% Done:

0%

Source:
Community (user)
Tags:
Backport:
hammer, firefly
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:

Description

user deleted the bucket a rule referred to. now a mapping crashes.

sample map attached (crushtool --test to reproduce).

monmap.bin (1.24 KB) Sage Weil, 05/12/2015 09:02 PM


Related issues

Copied to Ceph - Backport #11740: crush: take crashes due to invalid arg Resolved 05/12/2015
Copied to Ceph - Backport #11741: crush: take crashes due to invalid arg Resolved 05/12/2015

Associated revisions

Revision 9324d0a1 (diff)
Added by Sage Weil over 3 years ago

crush: fix crash from invalid 'take' argument

Verify that the 'take' argument is a valid device or bucket. Otherwise,
ignore it (do not add the value to the working vector).

Backport: hammer, firefly
Fixes: #11602
Reported-by: shiva rkreddy <>
Signed-off-by: Sage Weil <>

Revision 3d591afe (diff)
Added by Sage Weil over 3 years ago

mon: prevent bucket deletion when referenced by a rule

If a rule references a bucket with 'take', prevent deletion.

Fixes: #11602
Signed-off-by: Sage Weil <>

Revision f93eadd7 (diff)
Added by Sage Weil over 3 years ago

mon: prevent bucket deletion when referenced by a rule

If a rule references a bucket with 'take', prevent deletion.

Fixes: #11602
Signed-off-by: Sage Weil <>
(cherry picked from commit 3d591afef90b0601572c748f13faac029d05f5a0)

Revision 56565ee1 (diff)
Added by Sage Weil over 3 years ago

crush: fix crash from invalid 'take' argument

Verify that the 'take' argument is a valid device or bucket. Otherwise,
ignore it (do not add the value to the working vector).

Backport: hammer, firefly
Fixes: #11602
Reported-by: shiva rkreddy <>
Signed-off-by: Sage Weil <>
(cherry picked from commit 9324d0a1af61e1c234cc48e2175b4e6320fff8f4)

Revision bd91fb02 (diff)
Added by Sage Weil over 3 years ago

mon: prevent bucket deletion when referenced by a rule

If a rule references a bucket with 'take', prevent deletion.

Fixes: #11602
Signed-off-by: Sage Weil <>
(cherry picked from commit 3d591afef90b0601572c748f13faac029d05f5a0)

History

#1 Updated by Sage Weil over 3 years ago

#3 Updated by Loic Dachary over 3 years ago

  • Status changed from New to Need Review

#4 Updated by Kefu Chai over 3 years ago

  • Status changed from Need Review to Pending Backport

#5 Updated by Nathan Cutler about 3 years ago

  • Status changed from Pending Backport to Resolved

Also available in: Atom PDF