Project

General

Profile

Bug #11256

rgw: object set attrs clobbers object removal bucket index update

Added by Yehuda Sadeh over 3 years ago. Updated over 3 years ago.

Status:
Resolved
Priority:
Urgent
Assignee:
Target version:
-
Start date:
03/27/2015
Due date:
% Done:

0%

Source:
other
Tags:
Backport:
firefly, hammer
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:

Description

  • fix in master commit:4e6a66b and commit:edc0627

Associated revisions

Revision 7538319d (diff)
Added by Yehuda Sadeh over 3 years ago

rgw: generate new tag for object when setting object attrs

Fixes: #11256
Backport: firefly, hammer

Beforehand we were reusing the object's tag, which is problematic as
this tag is used for bucket index updates, and we might be clobbering a
racing update (like object removal).

Signed-off-by: Yehuda Sadeh <>

Revision 62645d30 (diff)
Added by Yehuda Sadeh over 3 years ago

cls_rgw: use multimap to keep pending operations in bucket index

Fixes: #11256
Multiple concurrent requests might be sent using the same tag, need the
entry map to be able to hold multiple entries.

Signed-off-by: Yehuda Sadeh <>

Revision edc0627a (diff)
Added by Yehuda Sadeh over 3 years ago

rgw: generate new tag for object when setting object attrs

Fixes: #11256
Backport: firefly, hammer

Beforehand we were reusing the object's tag, which is problematic as
this tag is used for bucket index updates, and we might be clobbering a
racing update (like object removal).

Signed-off-by: Yehuda Sadeh <>

Revision 4e6a66b5 (diff)
Added by Yehuda Sadeh over 3 years ago

cls_rgw: use multimap to keep pending operations in bucket index

Fixes: #11256
Multiple concurrent requests might be sent using the same tag, need the
entry map to be able to hold multiple entries.

Signed-off-by: Yehuda Sadeh <>

Revision cb757137 (diff)
Added by Yehuda Sadeh over 3 years ago

rgw: generate new tag for object when setting object attrs

Fixes: #11256
Backport: firefly, hammer

Beforehand we were reusing the object's tag, which is problematic as
this tag is used for bucket index updates, and we might be clobbering a
racing update (like object removal).

Signed-off-by: Yehuda Sadeh <>
(cherry picked from commit edc0627a1dbeb66ea2f5f177f6ceca64559ff3d8)

Revision 7c7e651a (diff)
Added by Yehuda Sadeh over 3 years ago

cls_rgw: use multimap to keep pending operations in bucket index

Fixes: #11256
Multiple concurrent requests might be sent using the same tag, need the
entry map to be able to hold multiple entries.

Signed-off-by: Yehuda Sadeh <>
(cherry picked from commit 4e6a66b55e73c01347fc3330faa5c1307d29e9d3)

History

#1 Updated by Ian Colle over 3 years ago

  • Status changed from New to Testing

#2 Updated by Yehuda Sadeh over 3 years ago

  • Status changed from Testing to Need Review
  • Assignee changed from Yehuda Sadeh to Josh Durgin
  • Backport changed from firefly to firefly, hammer

#3 Updated by Yehuda Sadeh over 3 years ago

  • Status changed from Need Review to Pending Backport
fixes merged into hammer
  • hammer backport commit:7c7e651 and commit:cb75713

#4 Updated by Loic Dachary over 3 years ago

  • Description updated (diff)
  • Regression set to No

#5 Updated by Loic Dachary over 3 years ago

  • Description updated (diff)

#7 Updated by Nathan Cutler over 3 years ago

both hammer and firefly backports appear to have been merged - does that mean this issue can be closed?

#8 Updated by Loic Dachary over 3 years ago

  • Status changed from Pending Backport to Resolved

Also available in: Atom PDF