Project

General

Profile

Bug #11101

ceph tell: broken error message / misleading hinting

Added by Federico Lucifredi about 2 years ago. Updated 6 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
-
Start date:
03/11/2015
Due date:
% Done:

0%

Source:
other
Tags:
Backport:
hammer
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Release:
Needs Doc:
No

Description

Description of problem:

root@master:~# ceph osd tell
"osd tell" is deprecated; try "tell osd.<id>" instead (id can be "*") 
root@master:~# ceph tell osd.*
Cannot use 'tell' with interactive mode
root@master:~#

Expected results:

I am not in interactive mode!

Besides that, I'd want the hint to point me to something I can try out without further understanding, like

"osd tell" is deprecated; try "tell osd.<id> bench" instead (id can be "*")

"ceph osd tell" is mentioned in the "top 10 commands" blogs in several places and on the ceph wiki - separately requested a fix there. That gets users started down this path, just like it did me.


Related issues

Copied to Backport #12494: ceph tell: broken error message / misleading hinting Resolved 03/11/2015

Associated revisions

Revision 972dc914 (diff)
Added by Kefu Chai almost 2 years ago

ceph.in: print more detailed error message for 'tell' command

  • we do not allow user specify a certain daemon when starting an
    interactive session. the existing error message could lead to
    some confusion. so put more details in it.

Fixes: #11101
Signed-off-by: Kefu Chai <>

Revision f18900f2 (diff)
Added by Kefu Chai almost 2 years ago

ceph.in: print more detailed error message for 'tell' command

  • we do not allow user specify a certain daemon when starting an
    interactive session. the existing error message could lead to
    some confusion. so put more details in it.

Fixes: #11101
Signed-off-by: Kefu Chai <>
(cherry picked from commit 972dc9145235ff0f60663369ebcab8c16628b89f)

Revision e19e8f15 (diff)
Added by Kefu Chai over 1 year ago

ceph.in: improve the error message

Fixes: #11101
Signed-off-by: Kefu Chai <>

Revision a3ba985c (diff)
Added by Kefu Chai 6 months ago

ceph.in: improve the error message

Fixes: #11101
Signed-off-by: Kefu Chai <>
(cherry picked from commit e19e8f1553fdf8b6b642d3222d28f242fab696f0)

History

#1 Updated by Kefu Chai almost 2 years ago

  • Description updated (diff)
  • Regression set to No

#2 Updated by Kefu Chai almost 2 years ago

  • Status changed from New to Need Review
  • Assignee set to Kefu Chai

#3 Updated by Ken Dreyer almost 2 years ago

  • Backport set to hammer

Thanks!

#4 Updated by Kefu Chai almost 2 years ago

  • Status changed from Need Review to Pending Backport

#5 Updated by Loic Dachary over 1 year ago

  • Status changed from Pending Backport to Resolved

#6 Updated by Kefu Chai over 1 year ago

  • Status changed from Resolved to Need Review

#7 Updated by Kefu Chai over 1 year ago

per Harish

We need to change the message something like this:

"Ceph 'tell' requires additional arguments. <print usage for tell command>"

#9 Updated by Kefu Chai over 1 year ago

  • Status changed from Need Review to Pending Backport

#10 Updated by Loic Dachary over 1 year ago

  • Status changed from Pending Backport to Resolved

#11 Updated by Kefu Chai 9 months ago

  • Status changed from Resolved to Pending Backport

@Loïc, https://github.com/ceph/ceph/pull/7106 is not backported yet.

#13 Updated by Nathan Cutler 6 months ago

  • Status changed from Pending Backport to Resolved
  • Needs Doc set to No

Also available in: Atom PDF