Project

General

Profile

Actions

Bug #11093

closed

Useless message when CephChoices n=N followed by additional parameters

Added by David Zafman about 9 years ago. Updated about 9 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
David Zafman
Category:
-
Target version:
-
% Done:

0%

Source:
other
Tags:
Backport:
Regression:
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

COMMAND("pg dump_stuck " \
"name=stuckops,type=CephChoices,strings=inactive|unclean|stale|undersized|degraded,n=N,req=false " \
"name=threshold,type=CephInt,req=false",
"show information about stuck pgs",\
"pg", "r", "cli,rest")

$ ceph pg dump_stuck 30
30 not valid: 30 not in inactive|unclean|stale|undersized|degraded
ok

As we can see the correct information was passed to the mon:

2015-03-10 18:58:47.596139 7fd2117e6700 7 mon.a@0(leader).log v53 update_from_paxos applying incremental log 53 2015-03-10 18:58:47.537685 mon.0 127.0.0.1:6789/0 95 : audit [DBG] from='client.? 127.0.0.1:0/1054778' entity='client.admin' cmd=[{"threshold": 30, "prefix": "pg dump_stuck"}]: dispatch

Cause by 71ff794eca7dd57a0b0473530f685069ac9987f0

Maybe there are other scenarios in which we want to see a warning, but in the example I found, it is just confusing to the user.

Actions #1

Updated by David Zafman about 9 years ago

  • Status changed from New to In Progress
Actions #2

Updated by David Zafman about 9 years ago

  • Status changed from In Progress to Fix Under Review
Actions #3

Updated by David Zafman about 9 years ago

  • Status changed from Fix Under Review to Resolved
Actions

Also available in: Atom PDF