Actions
Bug #11092
closedceph pg dump_stuck doesn't handle list properly
Status:
Resolved
Priority:
Normal
Assignee:
David Zafman
Category:
-
Target version:
-
% Done:
0%
Source:
other
Tags:
Backport:
Regression:
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):
Description
The fix for tracker #5332 was not correct. Even though the monitor code passes a vector to PGMonitor::dump_stuck_pg_stats() that function only looks at the first element. The fix is either to support multiple elements or switch to a single string and set n=1 in the command interface. This would also be a usage change.
Keep in mind that the type of "StuckPG" is an enum. We could create a bit mask of PG_STATE_* values from the vector of stuck type names. If get_stuck_stats() were passed a mask it could have to check for all matching states and assuming any one was over the threshold count include it. When specifying multiple states, a pg returned doesn't tell you which of the 1 or more states are over the threshold.
Updated by David Zafman about 9 years ago
- Assignee changed from Zhi Zhang to David Zafman
Updated by David Zafman about 9 years ago
- Status changed from New to In Progress
Updated by David Zafman about 9 years ago
- Status changed from In Progress to Fix Under Review
Updated by David Zafman about 9 years ago
- Status changed from Fix Under Review to Resolved
Actions