Ceph » CephFS

It won't patch on samba 4.1.16 (latest) source. Did you grab a different version?

Tried it. Patched successful. But not entirely fixed though, it seems that the timestamp "created timestamp" also changes unintentionally (tested on ms office .docx files). Plain textfiles (edited with notepad) is still working as intended (e.g. only modified/access time changes, not the creation time).

ceph inode does not store birth time. ceph vfs module assigns 'modified time' to 'birth time'

I wonder how other Linux filesystems keep track of creation times. Are they just storing them in an xattr or something?

Reporting an mtime as a creation time is fairly misleading, I think I'd rather we just set it to the Unix epoch or something to make clear that it's not really correct...which is apparently what we're actually doing if it reverts to 1970.

It doesn't build after patching:

[3740/3767] Linking default/source3/modules/libvfs-ceph.so
default/source3/modules/vfs_ceph_80.o: In function `cephwrap_stat':
vfs_ceph.c:(.text+0x1f91): undefined reference to `lp_fake_directory_create_times'
default/source3/modules/vfs_ceph_80.o: In function `cephwrap_fstat':
vfs_ceph.c:(.text+0x22b2): undefined reference to `lp_fake_directory_create_times'
default/source3/modules/vfs_ceph_80.o: In function `cephwrap_lstat':
vfs_ceph.c:(.text+0x24fd): undefined reference to `lp_fake_directory_create_times'
collect2: error: ld returned 1 exit status
Waf: Leaving directory `/usr/src/samba-4.1.16/bin'
Build failed:  -> task failed (err #1): 
        {task: cc_link vfs_ceph_80.o -> libvfs-ceph.so}
make: *** [all] Error 1

Hi Zheng, I was wondering if there is any progress with the above?

He's on vacation for Chinese New Year, and the rest of us are traveling. This'll probably require some work to get it going properly; have patience! :)

I will :-)
Thanks for the reply Greg!

try replacing "lp_fake_directory_create_times" in the patch with "lp_fake_dir_create_times"

Replaced it and it builds, but the problem still exists.
The created time == modified time after editing.

please check how samba behave when using local file system as backbend. I think this patch make ceph backend behave the same as local filesystem

When I use the local filesystem or even cephfs with the kernel module (instead of ceph vfs) everything is working fine. Timestamps are shown correctly, for both created time and modified time. This patch didn't work for me when using the ceph vfs samba module, specifically on MS Office files (.docx).

It won't patch. Hunk #1 failures.
Is it for SAMBA 4.1.16? I see a couple of discrepancies in the patches.

Are the previous patches also needed?

Awesome Zheng! It seems to be working correctly now.
I've only used the patches 0000-, 0001- and 0002-

Thank you.

After some more testing, I've noticed it still doesn't work perfectly.
My setup is as follows for test purposes:
I have two samba servers:
- samba1 has a cephfs kernel mount, which is exported in SAMBA (e.g. /mnt/cephfs/test)
- samba2 has the ceph_vfs module from samba, which is configure in SAMBA to point to the same share in cephfs (e.g. /test). This server has implemented above patches.

Both samba servers are being accessed from a Windows client.

Scenario 1:
1. samba1 is being accessed by the client and creates a .docx file. Timestamps are correctly shown.
2. client modifies the file (after 1 minute). Timestamps are correctly shown: Creation time is untouched, and the modified and accessed time is correctly adjusted.

Scenario 2:
1. samba2 is being accessed by the client and creates a .docx file. Timestamps are correctly shown.
2. client modifies the file (after 1 minute). Timestamps are correctly shown: Creation time is untouched, and the modified and accessed time is correctly adjusted.

Scenario 3:
1. samba2 is being accessed by the client and creates a .docx file. Timestamps are correctly shown.
2. client modifies the file (after 1 minute). Timestamps are correctly shown: Creation time is untouched, and the modified and accessed time is correctly adjusted.
3. client modifies the same file again (after 1 minute), but this time the client uses the server samba1 instead of samba2. Timestamps are now incorrectly shown: Creation time has the same timestamp as the modified time. This is shown on the file properties on server samba2, however when I look at the same file properties on server samba1 the timestamps are correct. Creation time seems untouched, and only the modified and accessed time is correctly adjusted. So both servers are showing different creation times on the same file in the situation when the file is modified on samba1 and read on samba2.

Zheng, I've compiled your patches against Samba v4.2.0rc5 and it seems to work now for scenario 3 aswell. So far so good :-)

Sorry, I was wrong.
Even with Samba v4.2.0rc5 the problem exists for "scenario 3" in my comment above.

Okay, I've noticed that when I restart the samba process the timestamps are shown correctly as expected, however when I edit the file again on samba1 (when using the same test-setup as described above) it shows the incorrect timestamps again on samba2.

do both of your samba servers have "store dos attributes" option enabled.

yes they do.

My smb.conf is as follows:

[global]
workgroup = DOMAIN
realm = FQDN
netbios name = samba2
server string = Ubuntu - samba2
kerberos method = secrets and keytab
client signing = yes
client use spnego = yes
security = ADS
os level = 0
lm announce = no
preferred master = no
local master = no
domain master = no
encrypt passwords = true
log level = 0 vfs:0
syslog = 2
log file = /var/log/samba/samba.log
max log size = 10000000
bind interfaces only = yes
interfaces = 127.0.0.1 172.17.135.111
client max protocol = SMB3
server max protocol = SMB3
acl allow execute always = True
store dos attributes = yes
dfree cache time = 60
dfree command = /usr/bin/dfree

1. Tuneables
   socket options = TCP_NODELAY IPTOS_LOWDELAY SO_KEEPALIVE
   strict sync = no
   sync always = no
   dead time = 15
   large readwrite = yes
   strict locking = no
   dns proxy= no
   max xmit = 1048576
   read raw = yes
   write raw = yes
   use sendfile = no
   oplocks = 0
   level2 oplocks = 0
   getwd cache = yes
2. TEST TUNABLES
   strict allocate = Yes
   aio read size = 16384
   aio write size = 16384
   smb2 leases = yes

1. ADS IDMAPPER <-> UID
   winbind separator = +
   idmap backend = tdb
   idmap uid = 50000 - 99999
   idmap gid = 50000 - 99999
   idmap config DOMAIN : backend = ad
   idmap config DOMAIN : schema_mode = rfc2307
   idmap config DOMAIN : readonly = yes
   idmap config DOMAIN : range = 50000 - 99999
   idmap cache time = 120
   idmap negative cache time = 20
   winbind nss info = rfc2307
   winbind expand groups = 2
   winbind nested groups = yes
   winbind use default domain = no
   winbind enum users = yes
   winbind enum groups = yes
   winbind refresh tickets = yes
   winbind offline logon = false
   obey pam restrictions = yes
   client ntlmv2 auth = yes

1. DISABLE CUPS
   load printers = no
   printing = bsd
   printcap name = /dev/null
   disable spoolss = yes

#================ Share Definitions ===================
[TEMPUS]
comment = TEMPUS SHARE
browseable = yes
read only = no
nt acl support = yes
create mask = 0664
directory mask = 2775
valid users = @BOFH
force group = BOFH
vfs objects = ceph recycle
path = /FIG
recycle:repository = .recycle
recycle:keeptree = yes
recycle:versions = yes
recycle:maxsize = 20971520
recylce:touch = yes
recylce:exclude = .tmp|.temp|*.o|*.obj
recycle:directory_mode = 2775

sound like a libcephfs bug. could you please try the newest development version of ceph (just need to update ceph on machine that run samba server, no need to update ceph on machine run osd/mds/mon)