Project

General

Profile

Actions

Bug #10787

closed

mon: OSDMonitor::map_cache is buggy, send_incremental is not conservative

Added by Sage Weil about 9 years ago. Updated about 9 years ago.

Status:
Resolved
Priority:
Urgent
Assignee:
Category:
-
Target version:
-
% Done:

0%

Source:
Q/A
Tags:
Backport:
giant,firefly
Regression:
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

2015-02-06 22:29:31.387753 7fed116df700 10 mon.peon5752@0(leader).osd e598595 preprocess_pgtemp osd_pgtemp(e598591 {5.7e99=[37,536,882],5.98a4=[482,738,869],5.f15b=[180,778,585],11.7e93=[37,536,882],11.989e=[482,738,869],11.f155=[180,778,585]} v598591) v1
2015-02-06 22:29:31.387773 7fed116df700  7 mon.peon5752@0(leader).osd e598595 preprocess_pgtemp e598591 no changes from osd.807 [2607:f298:4:2243::5522]:6828/3810
2015-02-06 22:29:31.387779 7fed116df700  7 mon.peon5752@0(leader).osd e598595 _reply_map 598591 from osd.807 [2607:f298:4:2243::5522]:6828/3810
2015-02-06 22:29:31.387783 7fed116df700  5 mon.peon5752@0(leader).osd e598595 send_latest to osd.807 [2607:f298:4:2243::5522]:6828/3810 start 598591
2015-02-06 22:29:31.387787 7fed116df700  5 mon.peon5752@0(leader).osd e598595 send_incremental [598591..598595] to osd.807 [2607:f298:4:2243::5522]:6828/3810
2015-02-06 22:29:31.387792 7fed116df700 10 mon.peon5752@0(leader).osd e598595  osd.807 should have epoch <b>594144</b>
2015-02-06 22:29:31.387794 7fed116df700 10 mon.peon5752@0(leader).osd e598595 build_incremental [594145..594245]

the passed-in first is > (much >!) the cached map value.

we should maybe only use the cached value here if it is larger, update the map_cache while we are here so that we do have the best value for this osd...

Actions #1

Updated by Sage Weil about 9 years ago

  • Status changed from New to Fix Under Review
Actions #2

Updated by Sage Weil about 9 years ago

  • Status changed from Fix Under Review to Pending Backport
Actions #4

Updated by Loïc Dachary about 9 years ago

  • Backport changed from giant,firefy to giant,firefly
Actions #5

Updated by Loïc Dachary about 9 years ago

92c352d mon/OSDMonitor: do not trust small values in osd epoch cache (in giant), 27dbbb3 mon/OSDMonitor: do not trust small values in osd epoch cache (in firefly),

Actions #6

Updated by Loïc Dachary about 9 years ago

  • Status changed from Pending Backport to Resolved
Actions

Also available in: Atom PDF