Project

General

Profile

Bug #10157

PGLog::(read|write)_log don't write out rollback_info_trimmed_to

Added by Samuel Just almost 4 years ago. Updated over 3 years ago.

Status:
Resolved
Priority:
High
Assignee:
Category:
-
Target version:
-
Start date:
11/20/2014
Due date:
% Done:

0%

Source:
other
Tags:
Backport:
giant,firefly
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:

Description

In practice, this means that replicated pgs will scan their log on the first operations after boot needlessly. EC pgs will tend to send an unnecessary transaction with the first operation after boot.


Related issues

Related to Ceph - Bug #11152: "Crash: 'wait_until_healthy'" in upgrade:giant-giant-distro-basic-vps run Resolved 03/18/2015
Duplicated by Ceph - Bug #9971: OSD crashes again after restarting due to op thread time out at writing pg dirty log Duplicate 10/30/2014

Associated revisions

Revision 1fe8b846 (diff)
Added by Samuel Just almost 4 years ago

PGLog: include rollback_info_trimmed_to in (read|write)_log

Fixes: #10157
Backport: firefly, giant
Signed-off-by: Samuel Just <>

Revision c60da2f3 (diff)
Added by Samuel Just over 3 years ago

PGLog: include rollback_info_trimmed_to in (read|write)_log

Fixes: #10157
Backport: firefly, giant
Signed-off-by: Samuel Just <>
(cherry picked from commit 1fe8b846641486cc294fe7e1d2450132c38d2dba)

Conflicts:
src/osd/PGLog.cc
in the context coll_t::META_COLL was replaced with META_COLL

Revision fea29b1b (diff)
Added by Samuel Just over 3 years ago

PGLog: include rollback_info_trimmed_to in (read|write)_log

Fixes: #10157
Backport: firefly, giant
Signed-off-by: Samuel Just <>
(cherry picked from commit 1fe8b846641486cc294fe7e1d2450132c38d2dba)

History

#1 Updated by Samuel Just almost 4 years ago

  • Status changed from New to Testing

#2 Updated by Samuel Just almost 4 years ago

  • Status changed from Testing to Pending Backport
  • Backport set to giant,firefly

#3 Updated by Dong Lei almost 4 years ago

Hi sam:

"EC pgs will tend to send an unnecessary transaction with the first operation after boot."

This unnecessary transaction is supposed to be very big if the log tail is far away from the last rollback_info_trimmed_to(before reboot), right?

#4 Updated by Samuel Just almost 4 years ago

  • Status changed from Pending Backport to Testing

#5 Updated by Samuel Just almost 4 years ago

  • Status changed from Testing to Pending Backport

#7 Updated by Loic Dachary over 3 years ago

fea29b1 PGLog: include rollback_info_trimmed_to in (read|write)_log (in giant), c60da2f PGLog: include rollback_info_trimmed_to in (read|write)_log (in firefly),

#8 Updated by Loic Dachary over 3 years ago

  • Status changed from Pending Backport to Resolved

Also available in: Atom PDF