Bug #10131: kclient: dentry still in use on umount - CephFS - Ceph

Actions

Copy link

Bug #10131

closed

kclient: dentry still in use on umount

Added by Greg Farnum over 9 years ago. Updated almost 8 years ago.

Status:

Resolved

Priority:

High

Assignee:

Zheng Yan

Category:

Target version:

% Done:

Source:

Q/A

Tags:

Backport:

Regression:

Severity:

3 - minor

Reviewed:

Affected Versions:

ceph-qa-suite:

Component(FS):

kceph

Labels (FS):

Pull request ID:

Crash signature (v1):

Crash signature (v2):

Description

2014-11-17T06:27:33.560178-08:00 plana11 kernel: [ 6921.831860] BUG: Dentry ffff88001d4a57a0{i=10000027ed2,n=mdp}  still in use (5) [unmount of ceph ceph]
2014-11-17T06:27:33.560209-08:00 plana11 kernel: [ 6921.841322] ------------[ cut here ]------------
2014-11-17T06:27:33.560216-08:00 plana11 kernel: [ 6921.846027] WARNING: CPU: 0 PID: 17542 at /srv/autobuild-ceph/gitbuilder.git/build/fs/dcache.c:1287 umount_check+0x87/0x90()
2014-11-17T06:27:33.649215-08:00 plana11 kernel: [ 6921.857347] Modules linked in: ceph(E) libceph(E) kvm_intel(E) kvm(E) ufs(E) qnx4(E) hfsplus(E) hfs(E) minix(E) ntfs(E) msdos(E) jfs(E) xfs(E) reiserfs(E) ext2(E) ib_iser(E) rdma_cm(E) ib_cm(E) iw_cm(E) ib_sa(E) ib_mad(E) ib_core(E) ib_addr(E) iscsi_tcp(E) libiscsi_tcp(E) libiscsi(E) nfsd(E) nfs_acl(E) auth_rpcgss(E) nfs(E) fscache(E) lockd(E) sunrpc(E) psmouse(E) gpio_ich(E) i7core_edac(E) acpi_power_meter(E) ipmi_si(E) edac_core(E) dcdbas(E) serio_raw(E) joydev(E) grace(E) ipmi_msghandler(E) tpm_tis(E) lpc_ich(E) scsi_transport_iscsi(E) lp(E) parport(E) btrfs(E) hid_generic(E) usbhid(E) ixgbe(E) dca(E) ptp(E) hid(E) raid6_pq(E) pps_core(E) mdio(E) mptsas(E) mptscsih(E) mptbase(E) scsi_transport_sas(E) bnx2(E) xor(E) libcrc32c(E) [last unloaded: kvm]
2014-11-17T06:27:33.649232-08:00 plana11 kernel: [ 6921.925795] CPU: 0 PID: 17542 Comm: umount Tainted: G          I E  3.18.0-rc4-ceph-00016-g618c03a #1
2014-11-17T06:27:33.649236-08:00 plana11 kernel: [ 6921.935110] Hardware name: Dell Inc. PowerEdge R410/01V648, BIOS 1.6.3 02/07/2011
2014-11-17T06:27:33.667223-08:00 plana11 kernel: [ 6921.942685]  0000000000000507 ffff88022038bcc8 ffffffff8172d26c ffff88022720f2d8
2014-11-17T06:27:33.674812-08:00 plana11 kernel: [ 6921.950293]  0000000000000000 ffff88022038bd08 ffffffff810541ec ffff88022038bd30
2014-11-17T06:27:33.687234-08:00 plana11 kernel: [ 6921.957890]  ffff880131dd5680 ffff88001d4a5820 0000000000035db4 ffff88009e7aac60
2014-11-17T06:27:33.687246-08:00 plana11 kernel: [ 6921.965484] Call Trace:
2014-11-17T06:27:33.687251-08:00 plana11 kernel: [ 6921.967951]  [<ffffffff8172d26c>] dump_stack+0x4e/0x68
2014-11-17T06:27:33.687254-08:00 plana11 kernel: [ 6921.973171]  [<ffffffff810541ec>] warn_slowpath_common+0x8c/0xc0
2014-11-17T06:27:33.699224-08:00 plana11 kernel: [ 6921.979255]  [<ffffffff8105423a>] warn_slowpath_null+0x1a/0x20
2014-11-17T06:27:33.699237-08:00 plana11 kernel: [ 6921.985169]  [<ffffffff811e5b37>] umount_check+0x87/0x90
2014-11-17T06:27:33.709569-08:00 plana11 kernel: [ 6921.990562]  [<ffffffff811e808d>] d_walk+0xcd/0x3b0
2014-11-17T06:27:33.709584-08:00 plana11 kernel: [ 6921.995521]  [<ffffffff811e858a>] ? do_one_tree+0x2a/0x50
2014-11-17T06:27:33.720428-08:00 plana11 kernel: [ 6922.000998]  [<ffffffff811e5ab0>] ? d_validate+0xc0/0xc0
2014-11-17T06:27:33.720442-08:00 plana11 kernel: [ 6922.006388]  [<ffffffff811e858a>] do_one_tree+0x2a/0x50
2014-11-17T06:27:33.732162-08:00 plana11 kernel: [ 6922.011692]  [<ffffffff811e8efd>] shrink_dcache_for_umount+0x2d/0x90
2014-11-17T06:27:33.732177-08:00 plana11 kernel: [ 6922.018129]  [<ffffffff811d199c>] generic_shutdown_super+0x2c/0x110
2014-11-17T06:27:33.744114-08:00 plana11 kernel: [ 6922.024426]  [<ffffffff811d1b16>] kill_anon_super+0x16/0x30
2014-11-17T06:27:33.744130-08:00 plana11 kernel: [ 6922.030090]  [<ffffffffa075d199>] ceph_kill_sb+0x39/0x70 [ceph]
2014-11-17T06:27:33.756463-08:00 plana11 kernel: [ 6922.036091]  [<ffffffff811d2159>] deactivate_locked_super+0x59/0x80
2014-11-17T06:27:33.756478-08:00 plana11 kernel: [ 6922.042444]  [<ffffffff811d29ce>] deactivate_super+0x4e/0x70
2014-11-17T06:27:33.767503-08:00 plana11 kernel: [ 6922.048185]  [<ffffffff811f0063>] cleanup_mnt+0x43/0x90
2014-11-17T06:27:33.767517-08:00 plana11 kernel: [ 6922.053492]  [<ffffffff811f0102>] __cleanup_mnt+0x12/0x20
2014-11-17T06:27:33.778442-08:00 plana11 kernel: [ 6922.058970]  [<ffffffff81072404>] task_work_run+0xb4/0xe0
2014-11-17T06:27:33.778457-08:00 plana11 kernel: [ 6922.064436]  [<ffffffff8100301a>] do_notify_resume+0xaa/0xc0
2014-11-17T06:27:33.789397-08:00 plana11 kernel: [ 6922.070179]  [<ffffffff81737147>] int_signal+0x12/0x17
2014-11-17T06:27:33.789411-08:00 plana11 kernel: [ 6922.075398] ---[ end trace fabba47e355c2939 ]---

There are dozens of these with slight variations at http://qa-proxy.ceph.com/teuthology/teuthology-2014-11-14_23:08:01-kcephfs-giant-testing-basic-multi/602806/remote/plana11/syslog/kern.log.gz

Actions

Copy link

Updated by Zheng Yan over 9 years ago

Status changed from New to In Progress
Assignee set to Zheng Yan

Actions

Copy link

Updated by Zheng Yan over 9 years ago

Status changed from In Progress to 7

it's a VFS bug. fixed by

diff --git a/fs/dcache.c b/fs/dcache.c
index 3ffef7f..5bc72b0 100644
--- a/fs/dcache.c
+++ b/fs/dcache.c
@@ -778,6 +778,7 @@ restart:
                        struct dentry *parent = lock_parent(dentry);
                        if (likely(!dentry->d_lockref.count)) {
                                __dentry_kill(dentry);
+                               dput(parent);
                                goto restart;
                        }
                        if (parent)

Actions

Copy link