General

Profile

Patrick Donnelly's activity

From 05/24/2018 to 06/22/2018

06/22/2018

11:25 PM CephFS Bug #24467 (Pending Backport): mds: low wrlock efficiency due to dirfrags traversal
Patrick Donnelly
11:21 PM Ceph Revision 03a8fe82 (ceph): Merge PR #22486 into master
* refs/pull/22486/head:
mds: avoid traversing all dirfrags when trying to get wrlocks
Reviewed-by: Zheng Yan <zyan@...
Patrick Donnelly
10:25 PM teuthology Revision cd9f4e3f (teuthology): build_matrix: ignore hidden files
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> Patrick Donnelly

06/20/2018

11:06 PM CephFS Bug #24522 (New): blogbench.sh failed in upgrade:luminous-x-mimic-distro-basic-smithi
Whoops! Patrick Donnelly
09:00 PM CephFS Bug #24522 (Duplicate): blogbench.sh failed in upgrade:luminous-x-mimic-distro-basic-smithi
Thanks Neha! Patrick Donnelly
05:10 PM CephFS Feature #17854 (Fix Under Review): mds: only evict an unresponsive client when another client wan...
Patrick Donnelly

06/19/2018

10:50 PM Ceph Revision 3854ee47 (ceph): client: delay dentry trimming until after cap traversal
Fixes: http://tracker.ceph.com/issues/24137
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked fro...
Patrick Donnelly
07:22 PM CephFS Documentation #24580 (Resolved): doc: complete documentation for `ceph fs` administration commands
Current skeleton: http://docs.ceph.com/docs/luminous/cephfs/administration/ Patrick Donnelly
06:09 PM CephFS Bug #24579: client: returning garbage (?) for readdir
This seems to only happen on Ubuntu 18.04:... Patrick Donnelly
06:05 PM CephFS Bug #24579: client: returning garbage (?) for readdir
Here too:
/ceph/teuthology-archive/teuthology-2018-06-18_20:06:42-powercycle-master-distro-basic-smithi/2678660
...
Patrick Donnelly
06:03 PM CephFS Bug #24579 (Resolved): client: returning garbage (?) for readdir
... Patrick Donnelly
02:13 PM Ceph Revision 111c515a (ceph): Merge PR #22569 into master
* refs/pull/22569/head:
qa/cephfs: add test for "dump inode"
mds: add dump inode command
Reviewed-by: Patrick Donn...
Patrick Donnelly

06/18/2018

09:19 PM CephFS Bug #24557 (Resolved): client: segmentation fault in handle_client_reply
... Patrick Donnelly
07:21 PM CephFS Backport #23833 (In Progress): luminous: MDSMonitor: crash after assigning standby-replay daemon ...
Patrick Donnelly
05:45 PM CephFS Feature #17230: ceph_volume_client: py3 compatible
There are high-level pushes to py3 in future (minor-)releases of Ceph/Openstack. RHCS 3.X (Luminous) will need to be ... Patrick Donnelly
05:42 PM CephFS Bug #24518 (Duplicate): "pjd.sh: line 7: cd: too many arguments" in fs suite
Yuri, you're using an old qa-suite branch. Thanks to Neha for noticing the cause. Patrick Donnelly
05:29 PM CephFS Bug #24518: "pjd.sh: line 7: cd: too many arguments" in fs suite
Line in question: https://github.com/ceph/ceph/blob/2d2293948066cae8d656dfe91bdb6695958a52e9/qa/workunits/suites/pjd.... Patrick Donnelly

06/15/2018

02:31 PM Ceph Revision c2311e1a (ceph): Merge PR #22340 into master
* refs/pull/22340/head:
doc: update description of mount options for cephfs
Reviewed-by: Zheng Yan <zyan@redhat.com>
Patrick Donnelly
02:06 PM CephFS Bug #24491 (Pending Backport): client: _ll_drop_pins travel inode_map may access invalid ‘next’ i...
Patrick Donnelly
02:05 PM Ceph Revision 4c3bf713 (ceph): Merge PR #22464 into master
* refs/pull/22464/head:
mds: print dir decay counters on hit
DecayCounter: removed unused velocity
DecayCounter: r...
Patrick Donnelly
02:05 PM Ceph Revision 8db4beda (ceph): Merge PR #22512 into master
* refs/pull/22512/head:
client: fix bug #24491 _ll_drop_pins may access invalid iterator
Reviewed-by: Patrick Donne...
Patrick Donnelly
02:04 PM Ceph Revision bc7cb579 (ceph): mds: use monotonic time for DecayCounter
This commit has a few side-effects:
- Decaying the DecayCounter is more accurate, we do not need to "skip" decaying
...
Patrick Donnelly
02:04 PM Ceph Revision 50c57391 (ceph): DecayCounter: remove unnecessary delta member
We can just add/sub to val directly (especially now that decay can be called on
a const DecayCounter).
Signed-off-by...
Patrick Donnelly
02:04 PM Ceph Revision 201cc8ea (ceph): DecayCounter: removed unused velocity
It's not actually used anywhere and it's not accurate.
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
Patrick Donnelly
02:04 PM Ceph Revision 35a7c01d (ceph): mds: print dir decay counters on hit
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> Patrick Donnelly
02:04 PM CephFS Bug #24440 (Pending Backport): common/DecayCounter: set last_decay to current time when decoding ...
Patrick Donnelly
02:03 PM CephFS Bug #24269 (Pending Backport): multimds pjd open test fails
Patrick Donnelly
02:02 PM CephFS Bug #24240 (Pending Backport): qa: 1 mutations had unexpected outcomes
Patrick Donnelly
02:02 PM Ceph Revision 9a3f8a14 (ceph): Merge PR #22357 into master
* refs/pull/22357/head:
common/DecayCounter: set last_decay to current time when decoding decay counter
Reviewed-by...
Patrick Donnelly
02:01 PM Ceph Revision c7951d8f (ceph): Merge PR #22289 into master
* refs/pull/22289/head:
mds: put Capability in map container
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Patrick Donnelly
02:01 PM Ceph Revision 88bf596a (ceph): Merge PR #22266 into master
* refs/pull/22266/head:
client: update inode fields according to issued caps
Reviewed-by: Patrick Donnelly <pdonne...
Patrick Donnelly
02:01 PM Ceph Revision 94445e64 (ceph): Merge PR #22234 into master
* refs/pull/22234/head:
mds: add magic to header of open file table
Reviewed-by: Patrick Donnelly <pdonnell@redhat....
Patrick Donnelly

06/14/2018

05:01 PM teuthology Bug #20538 (Resolved): AttributeError: 'tuple' object has no attribute 'split'
Patrick Donnelly
12:24 AM CephFS Bug #24306: mds: use intrusive_ptr to manage Message life-time
https://github.com/ceph/ceph/pull/22555 Patrick Donnelly

06/13/2018

06:50 PM Ceph Revision 84a39fe5 (ceph): qa: test for trim_caps segfault for trimmed dentries
Test case by Yan Zheng [1].
[1] http://tracker.ceph.com/issues/24137#note-6
Signed-off-by: Patrick Donnelly <pdonne...
Patrick Donnelly
02:57 PM CephFS Feature #21571: mds: limit number of snapshots (global and subtree)
There should be a global limit (if necessary for performance) and subtree limits (from #24429) so that operators can ... Patrick Donnelly
02:56 PM CephFS Feature #24429 (Duplicate): fs: implement snapshot count limit by subtree
Patrick Donnelly
02:06 PM CephFS Bug #19438 (Won't Fix): ceph mds error "No space left on device"
dirfrags are not stable on jewel. Closing this. Patrick Donnelly

06/08/2018

05:50 PM CephFS Feature #24464 (New): cephfs: file-level snapshots
Use-case is to support dropbox-style versioning of files. Patrick Donnelly
05:46 PM CephFS Feature #24463 (Resolved): kclient: add btime support
Patrick Donnelly
05:43 PM CephFS Feature #24462 (New): MDSMonitor: check for mixed version MDS
And create a health error if it detects this. Patrick Donnelly
05:10 PM CephFS Feature #24461 (Resolved): cephfs: improve file create performance buffering file unlink/create o...
**Serialized single-client** file creation (e.g. untar/rsync) is an area CephFS (and most distributed file systems) c... Patrick Donnelly

06/07/2018

01:11 PM CephFS Bug #24435 (Resolved): doc: incorrect snaprealm format upgrade process in mimic release note
Patrick Donnelly
01:07 PM CephFS Bug #24435 (Pending Backport): doc: incorrect snaprealm format upgrade process in mimic release note
Patrick Donnelly
01:11 PM CephFS Backport #24451 (Rejected): mimic: doc: incorrect snaprealm format upgrade process in mimic relea...
Nevermind, this doc doesn't exist in mimic. Patrick Donnelly
01:08 PM CephFS Backport #24451 (Rejected): mimic: doc: incorrect snaprealm format upgrade process in mimic relea...
Patrick Donnelly
01:06 PM Ceph Revision 84860eff (ceph): Merge PR #22445 into master
* refs/pull/22445/head:
doc: fix release notes on snapshot upgrades
Reviewed-by: Sage Weil <sage@redhat.com>
Review...
Patrick Donnelly

06/06/2018

10:31 PM Ceph Revision 95723e7d (ceph): Merge PR #22388 into master
* refs/pull/22388/head:
ceph-mds: Fix usage
doc: ceph-mds option updates
Reviewed-by: Patrick Donnelly <pdonnell@r...
Patrick Donnelly
10:28 PM CephFS Documentation #24093 (Resolved): doc: Update *remove a metadata server*
Patrick Donnelly
10:27 PM Ceph Revision 2f791848 (ceph): Merge PR #22338 into master
* refs/pull/22338/head:
doc: update toctree for add-remove-mds.rst
doc: create add/remove metadata server
Reviewed...
Patrick Donnelly
09:23 PM CephFS Bug #24435 (Fix Under Review): doc: incorrect snaprealm format upgrade process in mimic release note
https://github.com/ceph/ceph/pull/22445 Patrick Donnelly
09:17 PM CephFS Bug #24435 (In Progress): doc: incorrect snaprealm format upgrade process in mimic release note
Patrick Donnelly
09:22 PM Ceph Revision c1ed37c8 (ceph): doc: fix release notes on snapshot upgrades
Fixes: https://tracker.ceph.com/issues/24435
Introduced-by: d78dda7b812c63b5504f69e9df78bea4fbb37394.
Signed-off-by: ...
Patrick Donnelly
02:07 AM CephFS Feature #24430 (Resolved): libcephfs: provide API to change umask
The current use-case will be the CephFS shell. Patrick Donnelly

06/05/2018

09:05 PM CephFS Feature #24429 (Duplicate): fs: implement snapshot count limit by subtree
e.g. don't let a subtree have more than 7 snapshots. This should be configurable via an xattr.
Idea is from Dan va...
Patrick Donnelly
06:06 PM CephFS Feature #24426 (New): mds: add second level cache backed by local SSD or NVRAM
Idea is to have a second level to the MDS cache to improve access time and reduce reads on the metadata pool. This wo... Patrick Donnelly

06/04/2018

09:14 PM CephFS Bug #24241 (New): NFS-Ganesha libcephfs: Assert failure in object_locator_to_pg
Patrick Donnelly
06:15 PM CephFS Feature #24263: client/mds: create a merkle tree of objects to allow efficient generation of diff...
Sage Weil wrote:
> A few questions:
>
> - What is the sha1 of? The object's content? That isn't necessarily kno...
Patrick Donnelly
05:59 PM CephFS Feature #24263: client/mds: create a merkle tree of objects to allow efficient generation of diff...
John Spray wrote:
> Patrick Donnelly wrote:
> > John Spray wrote:
> > > I'm a fan. Questions that spring to mind:...
Patrick Donnelly
05:16 PM Ceph Bug #24196 (Closed): when i used 5 mechines,3monitor,3 mon mgr,5osd,but one of the osd cannot alive
Please take this question to the ceph-users mailing list. Patrick Donnelly
01:41 PM CephFS Bug #24306 (In Progress): mds: use intrusive_ptr to manage Message life-time
Patrick Donnelly

05/31/2018

09:38 AM Ceph Revision f0f005ba (ceph): client: fix error operator precedence
/home/pdonnell/ceph/src/client/Client.cc: In member function ‘int Client::mount(const string&, const UserPerm&, bool)... Patrick Donnelly
09:37 AM Ceph Revision 97f69520 (ceph): ceph-fuse: exit with failure on failed mount
Fixes: https://tracker.ceph.com/issues/23665
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked fr...
Patrick Donnelly
09:34 AM Ceph Revision b480de59 (ceph): client: do not overload system errnos
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 26f717361ea025462bc8016aca5a7c130048...
Patrick Donnelly
09:34 AM Ceph Revision c220207d (ceph): common: ignore errors during preforker exit
Caller can't do anything useful and it obsecures the error the caller wants to
return.
Signed-off-by: Patrick Donnel...
Patrick Donnelly
01:26 AM Ceph Revision a1a0e441 (ceph): mds: trim log during shutdown to clean metadata
Otherwise the trimming won't advance so that the remaining inodes are marked
clean.
Fixes: http://tracker.ceph.com/i...
Patrick Donnelly

05/25/2018

03:23 PM CephFS Bug #24306 (Resolved): mds: use intrusive_ptr to manage Message life-time
We're regularly getting bugs relating to messages not getting released. Latest one is #24289.
Use a boost::intrusi...
Patrick Donnelly
03:10 PM CephFS Feature #24233: Add new command ceph mds status
Vikhyat Umrao wrote:
> Thanks John and Patrick for the feedback. I think rename is not needed let us get a new comma...
Patrick Donnelly
02:51 PM CephFS Feature #24305 (Resolved): client/mds: allow renaming across quota boundaries
Issue here: https://github.com/ceph/ceph/blob/77b35faa36f83d837a5fe2685efcd4b9be59406a/src/client/Client.cc#L12214-L1... Patrick Donnelly
04:05 AM CephFS Bug #24052 (Pending Backport): repeated eviction of idle client until some IO happens
Patrick Donnelly
04:05 AM Ceph Revision 5362b910 (ceph): Merge PR #22026 into master
* refs/pull/22026/head:
mds: send cap export message when exporting non-auth caps to auth mds
Reviewed-by: Patrick ...
Patrick Donnelly
03:07 AM CephFS Feature #24286 (Resolved): tools: create CephFS shell
> The Ceph file system (CephFS) provides for kernel driver and FUSE client access. In testing and trivial system admi... Patrick Donnelly
02:31 AM CephFS Bug #24284: cephfs: allow prohibiting user snapshots in CephFS
Zheng Yan wrote:
> change default of mds_snap_max_uid to 0
Okay, but we should enforce that as a file system opti...
Patrick Donnelly
02:28 AM CephFS Feature #24285 (Resolved): mgr: add module which displays current usage of file system (`fs top`)
It would ideally provide a list of sessions doing I/O, what kind of I/O, bandwidth of reads/writes, etc. Also the sam... Patrick Donnelly
02:24 AM CephFS Documentation #23775 (Resolved): PendingReleaseNotes: add notes for major Mimic features
Patrick Donnelly
02:15 AM CephFS Feature #9659 (Duplicate): MDS: support cache eviction
Patrick Donnelly
01:46 AM CephFS Bug #23715 (Closed): "Scrubbing terminated -- not all pgs were active and clean" in fs-jewel-dist...
Problem seems to have gone away. Closing. Patrick Donnelly

05/24/2018

10:43 PM CephFS Feature #14456: mon: prevent older/incompatible clients from mounting the file system
We're moving this to target 13.2.1. Patrick Donnelly
10:40 PM CephFS Documentation #23775: PendingReleaseNotes: add notes for major Mimic features
https://github.com/ceph/ceph/pull/22232 Patrick Donnelly
10:38 PM Ceph Revision a89865b3 (ceph): doc/releases: update CephFS mimic notes
Fixes: http://tracker.ceph.com/issues/23775
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
Patrick Donnelly
10:27 PM CephFS Bug #24284 (Resolved): cephfs: allow prohibiting user snapshots in CephFS
Since snapshots can be used to circumvent (accidentally or not) the quotas as snapshot file data that has since been ... Patrick Donnelly
09:03 PM CephFS Feature #22370 (Resolved): cephfs: add kernel client quota support
Patrick Donnelly
07:21 PM CephFS Backport #24209 (Resolved): mimic: client: deleted inode's Bufferhead which was in STATE::Tx woul...
Patrick Donnelly
07:21 PM CephFS Bug #24111 (Resolved): mds didn't update file's max_size
Patrick Donnelly
07:21 PM CephFS Backport #24187 (Resolved): mimic: mds didn't update file's max_size
Patrick Donnelly
07:20 PM CephFS Backport #24254 (Resolved): mimic: kceph: umount on evicted client blocks forever
Patrick Donnelly
07:20 PM CephFS Backport #24255 (Resolved): mimic: qa: kernel_mount.py umount must handle timeout arg
Patrick Donnelly
07:17 PM CephFS Backport #24186 (Resolved): mimic: client: segfault in trim_caps
Patrick Donnelly
07:15 PM CephFS Backport #24202 (Resolved): mimic: client: fails to respond cap revoke from non-auth mds
Patrick Donnelly
07:14 PM CephFS Backport #24206 (Resolved): mimic: mds: broadcast quota to relevant clients when quota is explici...
Patrick Donnelly
07:14 PM CephFS Bug #24118 (Resolved): mds: crash when using `config set` on tracked configs
Patrick Donnelly
07:13 PM CephFS Backport #24157 (Resolved): mimic: mds: crash when using `config set` on tracked configs
Patrick Donnelly
07:13 PM CephFS Backport #24191 (Resolved): mimic: fs: reduce number of helper debug messages at level 5 for client
Patrick Donnelly
07:12 PM Ceph Revision aa04c276 (ceph): Merge PR #22136 into mimic
* refs/pull/22136/head:
client: avoid freeing inode when it contains TX buffer heads
Reviewed-by: Patrick Donnelly ...
Patrick Donnelly
07:12 PM Ceph Revision b105f463 (ceph): Merge PR #22137 into mimic
* refs/pull/22137/head:
mds: properly setup client_need_snapflush for snap inode
Revert "mds: properly setup need_s...
Patrick Donnelly
07:11 PM Ceph Revision bd14e01e (ceph): Merge PR #22138 into mimic
* refs/pull/22138/head:
mds: reply session reject for open request from blacklisted client
qa/tasks/cephfs: add tim...
Patrick Donnelly
07:11 PM Ceph Revision 5d94aa9e (ceph): Merge PR #22139 into mimic
* refs/pull/22139/head:
client: delay dentry trimming until after cap traversal
Reviewed-by: Patrick Donnelly <pdon...
Patrick Donnelly
07:11 PM Ceph Revision 3b749e95 (ceph): Merge PR #22140 into mimic
* refs/pull/22140/head:
client: fix issue of revoking non-auth caps
Reviewed-by: Patrick Donnelly <pdonnell@redhat....
Patrick Donnelly
07:11 PM Ceph Revision c84030b0 (ceph): Merge PR #22141 into mimic
* refs/pull/22141/head:
mds: broadcast quota to relevant clients when quota is explicitly set
Reviewed-by: Patrick ...
Patrick Donnelly
07:11 PM Ceph Revision 53b0daa4 (ceph): Merge PR #22153 into mimic
* refs/pull/22153/head:
mon/MonClient: set configs via finisher
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Patrick Donnelly
07:11 PM Ceph Revision 135344f1 (ceph): Merge PR #22154 into mimic
* refs/pull/22154/head:
client: increase verbosity level for log messages in helper methods
Reviewed-by: Patrick Do...
Patrick Donnelly
05:05 PM CephFS Feature #24263: client/mds: create a merkle tree of objects to allow efficient generation of diff...
John Spray wrote:
> I'm a fan. Questions that spring to mind:
>
> - Do we apply this to all files, or only large...
Patrick Donnelly
05:01 AM CephFS Bug #24241 (Need More Info): NFS-Ganesha libcephfs: Assert failure in object_locator_to_pg
What version of Ceph are you using? Patrick Donnelly
04:53 AM CephFS Backport #24185 (In Progress): luminous: client: segfault in trim_caps
Patrick Donnelly
 

Also available in: Atom