General

Profile

Adam Emerson's activity

From 04/19/2018 to 05/18/2018

05/18/2018

01:30 PM Ceph Revision f003c9b1 (ceph): tools: Do not memset uuid_d
It is perfectly able to default initialize itself.
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
(cherry pick...
Adam Emerson
01:30 PM Ceph Revision 51df344f (ceph): build: Remove -Wno-invalid-offsetof
Since C++17 relaxed the rules for using offsetof, this is no longer needed.
Signed-off-by: Adam C. Emerson <aemerson...
Adam Emerson
01:30 PM Ceph Revision 0e203975 (ceph): blkdev: Get rid of get_device_by_uuid
This function's interface is bad, in that it takes char*s with no
sizes. Also nobody calls it.
Signed-off-by: Adam C...
Adam Emerson
01:30 PM Ceph Revision ae6d2ebd (ceph): blkdev: Check return of snprintf and error on truncation
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
(cherry picked from commit 1683aed5395fb2c195a25715a3dedb83db871...
Adam Emerson
01:30 PM Ceph Revision c17dda54 (ceph): mon: Remove unused variable
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
(cherry picked from commit cfd425e319a28dfa472fd3e7532d7ef11cb88...
Adam Emerson
01:30 PM Ceph Revision 9a5e7210 (ceph): mount: Enlarge buffer to fix overflow warning
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
(cherry picked from commit 5ef603f388957b472326180a1e23ade61e80c...
Adam Emerson
01:30 PM Ceph Revision 6030cbb5 (ceph): perfglue: Silence truncation warning
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
(cherry picked from commit a0d15b915f8092f9cfcd19a700e7059dbdaa5...
Adam Emerson
01:30 PM Ceph Revision 048baf8c (ceph): FuseStore: Expand buffers to prevent overflow
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
(cherry picked from commit 4365b1d358cd18c90d6371c96f5bc1a7516cd...
Adam Emerson
01:30 PM Ceph Revision 1a5142c6 (ceph): rgw: Exceptions should be caught by const reference
/Not/ by value.
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
(cherry picked from commit 1065d7996e359283f0f3...
Adam Emerson
01:30 PM Ceph Revision 533a2d8d (ceph): msg/rdma/infiniband: Silence memset warning
Though it may be better in the long-run to replace the malloc-like
interface with an Allocator type interface.
Signe...
Adam Emerson
01:30 PM Ceph Revision 3c0ee374 (ceph): rdma: Silence qualifier warnings
No point in reinterpret_casting something const anyway, you can always
assign non-const to const.
Signed-off-by: Ada...
Adam Emerson
01:30 PM Ceph Revision 65a183fa (ceph): rgw: Remove extra 'const' from cast
Casting to pointer-to-const makes sense. Casting to a const
value (even a const pointer) doesn't.
Signed-off-by: Ada...
Adam Emerson
01:30 PM Ceph Revision d5b154f4 (ceph): rgw: Catch exceptions at const references
/Never/ by value.
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
(cherry picked from commit 25f6b639495ef90474...
Adam Emerson
01:30 PM Ceph Revision e7310b9a (ceph): rgw: There is no point in const return values
Pointer-to-const or reference-to-const yes. Const value, no.
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
(c...
Adam Emerson
01:30 PM Ceph Revision 7b5deac3 (ceph): test/libcephfs: Expand buffer slightly
So the snprintf output isn't truncated.
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
(cherry picked from com...
Adam Emerson
01:30 PM Ceph Revision c82d5da1 (ceph): test/rbd/fsx: Disable overflow-format warning
No return type or other way to react to it.
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
(cherry picked from...
Adam Emerson
01:30 PM Ceph Revision 0facc1d9 (ceph): rgw: Fix uninitialized value warning
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
(cherry picked from commit 27e95a4144a3caf40e4db6a82b93b792f4f9d...
Adam Emerson
01:30 PM Ceph Revision 3196b76a (ceph): test: Increase buffer to prevent possible truncation
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
(cherry picked from commit 5811a396e6602aaf792d69b23921b12632dfe...
Adam Emerson
01:30 PM Ceph Revision 7ba77bf0 (ceph): client: Do not memset frag_info_t and inode_t
They do a perfectly good job of initializing themselves.
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
(cherr...
Adam Emerson
01:30 PM Ceph Revision b249557f (ceph): auto: Catch exceptions by const reference
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
(cherry picked from commit 6e8188498e66ea46a58c6c46c44cecbb243d6...
Adam Emerson
01:30 PM Ceph Revision a63093be (ceph): mds: Do not memset fnode_t
fnode_t can initialize itself.
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
(cherry picked from commit 8dffe...
Adam Emerson
01:30 PM Ceph Revision e9bdd3ee (ceph): test: Enlarge a few buffers
To get rid of overflow warnings.
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
(cherry picked from commit d55...
Adam Emerson

05/09/2018

06:19 PM Ceph Revision 83ada189 (ceph): rgw: Silence sign comparison warnings
Since we're iterating with a size_t, we may as well compare against one.
Signed-off-by: Adam C. Emerson <aemerson@re...
Adam Emerson
05:26 PM Ceph Revision 27e95a41 (ceph): rgw: Fix uninitialized value warning
Signed-off-by: Adam C. Emerson <aemerson@redhat.com> Adam Emerson
05:26 PM Ceph Revision 5811a396 (ceph): test: Increase buffer to prevent possible truncation
Signed-off-by: Adam C. Emerson <aemerson@redhat.com> Adam Emerson
05:26 PM Ceph Revision d5adb05a (ceph): client: Do not memset frag_info_t and inode_t
They do a perfectly good job of initializing themselves.
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
Adam Emerson
05:26 PM Ceph Revision 6e818849 (ceph): auto: Catch exceptions by const reference
Signed-off-by: Adam C. Emerson <aemerson@redhat.com> Adam Emerson
05:26 PM Ceph Revision 8dffe4eb (ceph): mds: Do not memset fnode_t
fnode_t can initialize itself.
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
Adam Emerson
05:26 PM Ceph Revision d5504814 (ceph): test: Enlarge a few buffers
To get rid of overflow warnings.
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
Adam Emerson
05:26 PM Ceph Revision ef8465c2 (ceph): blkdev: Get rid of get_device_by_uuid
This function's interface is bad, in that it takes char*s with no
sizes. Also nobody calls it.
Signed-off-by: Adam C...
Adam Emerson
05:26 PM Ceph Revision 1683aed5 (ceph): blkdev: Check return of snprintf and error on truncation
Signed-off-by: Adam C. Emerson <aemerson@redhat.com> Adam Emerson
05:26 PM Ceph Revision cfd425e3 (ceph): mon: Remove unused variable
Signed-off-by: Adam C. Emerson <aemerson@redhat.com> Adam Emerson
05:26 PM Ceph Revision 5ef603f3 (ceph): mount: Enlarge buffer to fix overflow warning
Signed-off-by: Adam C. Emerson <aemerson@redhat.com> Adam Emerson
05:26 PM Ceph Revision a0d15b91 (ceph): perfglue: Silence truncation warning
Signed-off-by: Adam C. Emerson <aemerson@redhat.com> Adam Emerson
05:26 PM Ceph Revision 4365b1d3 (ceph): FuseStore: Expand buffers to prevent overflow
Signed-off-by: Adam C. Emerson <aemerson@redhat.com> Adam Emerson
05:26 PM Ceph Revision 1065d799 (ceph): rgw: Exceptions should be caught by const reference
/Not/ by value.
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
Adam Emerson
05:26 PM Ceph Revision 7fcfb601 (ceph): msg/rdma/infiniband: Silence memset warning
Though it may be better in the long-run to replace the malloc-like
interface with an Allocator type interface.
Signe...
Adam Emerson
05:26 PM Ceph Revision 7a551495 (ceph): rdma: Silence qualifier warnings
No point in reinterpret_casting something const anyway, you can always
assign non-const to const.
Signed-off-by: Ada...
Adam Emerson
05:26 PM Ceph Revision 46b40274 (ceph): rgw: Remove extra 'const' from cast
Casting to pointer-to-const makes sense. Casting to a const
value (even a const pointer) doesn't.
Signed-off-by: Ada...
Adam Emerson
05:26 PM Ceph Revision 25f6b639 (ceph): rgw: Catch exceptions at const references
/Never/ by value.
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
Adam Emerson
05:26 PM Ceph Revision 389538f3 (ceph): rgw: There is no point in const return values
Pointer-to-const or reference-to-const yes. Const value, no.
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
Adam Emerson
05:26 PM Ceph Revision 5bfcd233 (ceph): test/libcephfs: Expand buffer slightly
So the snprintf output isn't truncated.
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
Adam Emerson
05:26 PM Ceph Revision ff189df0 (ceph): test/rbd/fsx: Disable overflow-format warning
No return type or other way to react to it.
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
Adam Emerson
05:26 PM Ceph Revision c8766189 (ceph): tools: Do not memset uuid_d
It is perfectly able to default initialize itself.
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
Adam Emerson
05:26 PM Ceph Revision f9c5e282 (ceph): build: Remove -Wno-invalid-offsetof
Since C++17 relaxed the rules for using offsetof, this is no longer needed.
Signed-off-by: Adam C. Emerson <aemerson...
Adam Emerson
04:37 PM rgw Backport #24063 (Resolved): luminous: Misnamed S3 operation
https://github.com/ceph/ceph/pull/21917 Adam Emerson
04:37 PM rgw Backport #24062 (Resolved): mimic: Misnamed S3 operation
https://github.com/ceph/ceph/pull/21916 Adam Emerson
04:36 PM rgw Bug #24061 (Resolved): Misnamed S3 operation
s3:ListBucketMultiPartUploads should be s3:ListBucketMultipartUploads
Fixed in https://github.com/ceph/ceph/pull/...
Adam Emerson
04:28 PM Ceph Revision 89d1de62 (ceph): Merge pull request #20974 from XiangxiangMeng/rgw-policy-keyword-modify
rgw: policy: modify some operation permission keyword
Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
Reviewed-by...
Adam Emerson
04:06 PM Ceph Bug #22984 (Duplicate): RGWs crash when I try to set a policy
Adam Emerson

05/08/2018

05:57 PM Ceph Revision 5234c4e1 (ceph): build: Allow use of Clang to build Python extensions under Fedora 28
Fedora builds Python with hardening flags that are unsupported by
Clang. Python insists on building extensions with a...
Adam Emerson
05:57 PM Ceph Revision 33c8a43d (ceph): cleanup: Remove unused variables/captures
Signed-off-by: Adam C. Emerson <aemerson@redhat.com> Adam Emerson
 

Also available in: Atom